Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add progress text update #13

Closed
wants to merge 1 commit into from

Conversation

jeremy-kunzhou
Copy link

Just simple implement the progress text update
which could use with alamofire progress update block

By invoke SwiftOverlays.updateWaitOverlayText(text:), the text in label view, which is subview of the container overlay view, will be update

BTW, this method must be called in UI thread.

@peterprokop
Copy link
Owner

@Keane Thanks for the PR, appreciate it.
But it looks like while true loop in updateOverlayText method will just run endlessly if there is no overlay view present, which is not a great design solution.

@jeremy-kunzhou
Copy link
Author

That's my fault.

Thanks for your advice.

Do i need to make another pull request?

@peterprokop
Copy link
Owner

@Keane Please take a look at eb48681. It's basically the same as your code, but now it simply does nothing if no overlay is present.

Also, it's probably better to use UIProgressView for this (which I most likely implement in the nearest future).

@peterprokop peterprokop closed this Feb 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants