Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift3 #22

Closed
francoisduchemin opened this issue Sep 14, 2016 · 18 comments
Closed

Swift3 #22

francoisduchemin opened this issue Sep 14, 2016 · 18 comments

Comments

@francoisduchemin
Copy link

Hey Peter, thanks for your library.
Do you know how to include the swift 3 branch in carthage?

I tried to put the following string in my cartfile:
github "peterprokop/SwiftOverlays" "swift-3.0"

But when I update I get the following error messages:
SwiftOverlays/SwiftOverlays/SwiftOverlays.swift:303:27: error: value of type 'CGRect' has no member 'offsetInPlace'
SwiftOverlays/SwiftOverlays.swift:310:27: error: value of type 'CGRect' has no member 'offsetInPlace'
SwiftOverlays/SwiftOverlays/SwiftOverlays.swift:415:58: error: cannot call value of non-function type 'UIColor'
SwiftOverlays.swift:418:70: error: cannot call value of non-function type 'UIScreen'
SwiftOverlays/SwiftOverlays.swift:490:42: error: cannot call value of non-function type 'UIApplication'

Thanks,
Francois.

@ibakurov
Copy link

The same is happening with CocoaPods.

@emonfil87
Copy link

The same is happening with Manually installation.

@ibakurov
Copy link

changing offsetInPlace to offsetBy solved the issue.

@peterprokop
Copy link
Owner

@francoisduchemin @illyaBakurov @emonfil87 Guys, I've updated swift-3.0 branch, can you please check again? Will update CocoaPods when will have some free time.

@levibostian
Copy link

@peterprokop I ran the newly updated swift-3.0 branch and it works great from my testing. Simple overlay with text and then removing it.

@francoisduchemin
Copy link
Author

@peterprokop Same here everything is working fine with the the updated swift-3.0 branch. Thanks!

@giacgbj
Copy link

giacgbj commented Nov 28, 2016

@peterprokop What about merging this branch into the head?

@peterprokop
Copy link
Owner

@giacgbj sorry for the delays, was really busy. swift-3.0 is now merged to master

@giacgbj
Copy link

giacgbj commented Nov 28, 2016

@peterprokop Great! Waiting for the release to cleanup my Podfile :-)

@peterprokop
Copy link
Owner

@giacgbj
Copy link

giacgbj commented Nov 28, 2016

@peterprokop I just tested the methods I use in my application and they seem to work properly. In my opinion, you can release it.

@kevinkowalew
Copy link

I installed the most recent version (2.0.1) using Cocoapods, however, it appears to not be the updated Swift 3 version. Any ideas why this may be happening?

@peterprokop
Copy link
Owner

@kevinkowalew I still haven't updated the pod specs, will do that this evening (hopefully)

@kevinkowalew
Copy link

sounds great Peter, thanks!

@lucletruc
Copy link

@peterprokop agree with kevin, please fix faster :)

@peterprokop
Copy link
Owner

@kevinkowalew @lucletruc Guys, I've pushed new podspec. Can you please check if everything works as expected?

@lucletruc
Copy link

lucletruc commented Dec 3, 2016

@peterprokop ran pod update works like a charm 👍 :) thanks

@kevinkowalew
Copy link

same here, thanks Peter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants