New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the color of lost-utility: edit #127
Comments
Yeah I agree this would be nice. It will require breaking |
+1 For example, I made this simple codepen while trying to understand how offset works, enabled the utility, saw this: This unfortunately doesnt show the columns, nor gutters. Or maybe I'm missing something? I was hoping for something like this: |
@sdale-fevo This is a use case I hadn't thought of. Thanks for the input! I'll look to see how much effort this will be and see when we could slate this. Any chance you'd want to submit a PR for this yourself? |
Is there some cool way to make these faux grids now? Last time I checked it was a gradient and had rounding issues that made it inaccurate. I made this thingy a long time ago https://github.com/corysimmons/grid-overlay :) |
hmm, this is what I iterated on today, lemme know if worth to submit. S: 4 col I've used Enquire.js in our codebase to detect changes to media query size (for debugging/dev, not in production), then on change of our defined breakpoints, I'm injecting the number of Div's necessary into a helper class container The
then in my template, I'm doing:
Lastly, in my .js:
Close, in XL, looks something like this: When I go down to lower bpoints, I lose "sync, I think related to how I structured my media queries. One issue with this approach is that the # of columns for each breakpoint have to match from CS <--> JS, which is brittle. I'd prefer to have the col # and sizes specified once, but not sure how to do this.. Should probably look at Bourbon/Neat source.. @corysimmons They have off by one errors too in their debugger column display, it's a loose guide, I wouldnt worry about getting it pixel perfect. =: s |
@sdale-fevo This looks like some cool code but it might be a bit outside of the scope of Lost. I think what would be best is to enhance the current foo {
lost-utility: edit #fff;
} and foo {
lost-utility: edit;
lost-utility-color: #fff;
} Thoughts? |
I agree with @peterramsing Cool grid thing, and maybe worth doing a blog post on, but I think it's a bit outside Lost's scope as well. @peterramsing I like the first syntax but don't really think we need a Here, I made something that will provide full-height columns lined up perfectly with their columns: http://codepen.io/corysimmons/pen/jWLbZp?editors=110 The only caveat is if they are using |
Thanks for the feedback, I figured.. also thought it might be useful to someone reading this issue.. Re: the technique in the Codepen - do you forsee any issues with using Looking forward to this add .. =: s |
Didn't read the article but it seems like those mobile issues are mostly for older mobile browsers. |
this is now a pull request slated for v7.1.0 |
This is now in version 7.1.0. |
Nice. Thank you very much |
@AleksejDix Have you used it and is it working well? I think that I'm going to add the ability to just use some basic keywords such as the primary colors so that you don't have to create and Let me know how it's performing and if you have any additional feedback. Thanks~ |
would be nice to change the color of the edit mode.
like it was in the last versions
The text was updated successfully, but these errors were encountered: