Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget in miniplayer refreshes which causes an error. #22

Closed
eiler21 opened this issue Nov 10, 2021 · 2 comments
Closed

Widget in miniplayer refreshes which causes an error. #22

eiler21 opened this issue Nov 10, 2021 · 2 comments

Comments

@eiler21
Copy link

eiler21 commented Nov 10, 2021

I asked the same question on stackoverflow and after that found a solution. The problem is that miniplayer rebuilds its child widget when you start to dismiss it because of this line:
(value == 0) return child!;

This causes an error when for example using video_player. Because at the time you start dismissing the miniplayer the video is playing however then miniplayer rebuilds its child and the video_player gets black (or starts playing over from the start).

If you just delete the line I mentioned above nothing will change and the error will disappear.

dxvid-pts added a commit that referenced this issue Nov 10, 2021
@dxvid-pts
Copy link
Owner

Thank you for submitting.
This should be fixed now but feel free to reopen if the issue still occurs.

@zeddyyz
Copy link

zeddyyz commented Nov 9, 2022

Thank you @eiler21 for providing a solution. The current version of the package still presents the issue for me using just_audio package. Next, I copied the code for the package and made it local to my project. I removed the line if (value == 0) return child!; as you suggested to stop the widget from refreshing between max and min states, however my just_audio player refreshes the audio source between max/min state. Was that the only fix that worked for you or any ideas would be greatly appreciated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants