Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %w verb in t.Errorf calls #443

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

peterstace
Copy link
Owner

Description

This is to fix the following test build error:

$ go test ./geom
# github.com/peterstace/simplefeatures/geom_test
geom/alg_set_op_test.go:990:7: (*testing.common).Errorf does not support error-wrapping directive %w
geom/ctor_options_test.go:41:5: (*testing.common).Errorf does not support error-wrapping directive %w
FAIL    github.com/peterstace/simplefeatures/geom [build failed]
FAIL

Note that this error only seems to occur with go1.18. I'm not really sure why this is coming up as an actual compile error rather than a vet warning (I haven't looked into it).

Check List

Have you:

  • Added unit tests? N/A

  • Add cmprefimpl tests? (if appropriate?) N/A

  • Updated release notes? (if appropriate?) N/A

Related Issue

  • N/A

Benchmark Results

N/A

This is to fix the following test build error:

    $ go test ./geom
    # github.com/peterstace/simplefeatures/geom_test
    geom/alg_set_op_test.go:990:7: (*testing.common).Errorf does not support error-wrapping directive %w
    geom/ctor_options_test.go:41:5: (*testing.common).Errorf does not support error-wrapping directive %w
    FAIL    github.com/peterstace/simplefeatures/geom [build failed]
    FAIL

Note that this error only seems to occur with go1.18. I'm not really
sure why this is coming up as an actual compile error rather than a vet
warning (I haven't looked into it).
@peterstace peterstace self-assigned this Mar 18, 2022
@peterstace peterstace merged commit e05f565 into master Mar 21, 2022
@peterstace peterstace deleted the fix_pct_w_verb_in_Errorf branch March 21, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants