Fix Golangci Lint Integration #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterstace
commented
May 13, 2022
| @@ -10,9 +10,9 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Install dependencies | |||
| run: sudo apt update && sudo sudo apt install libgdal-dev libgeos-dev libproj-dev | |||
There was a problem hiding this comment.
Gdal and proj were unneeded.
| if b.IsEmpty() { | ||
| b, a = a, b | ||
| nonEmpty = a |
There was a problem hiding this comment.
This was to fix a lint error that complained that a was never used after this assignment. The lint error was accurate, and I think using a new nonEmpty variable better expresses what's going on here anyway.
| @@ -380,7 +380,7 @@ func TestEnvelopeInvalidXYInteractions(t *testing.T) { | |||
| t.Run(fmt.Sprintf("extend_to_include_invalid_xy_%d", i), func(t *testing.T) { | |||
| env, err := NewEnvelope([]XY{{-1, -1}, {1, 1}}) | |||
| expectNoErr(t, err) | |||
| env, err = env.ExtendToIncludeXY(tc) | |||
| _, err = env.ExtendToIncludeXY(tc) | |||
There was a problem hiding this comment.
This was to fix a lint error complaining that env was never used after this assignment (which was true!).
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Golangci-lint was reporting some false positives, e.g. https://github.com/peterstace/simplefeatures/actions/runs/2316868808
I'm not really sure why that started happening all of a sudden (if anyone has any theories, I'd love to know).
This PR upgrades to the latest golangci-lint version, and fixes some new lint problems identified. That seems to get the build green again.
Check List
Have you:
Added unit tests? N/A
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) N/A
Related Issue
N/A
Benchmark Results
N/A