Simplify the Type method of the Geometry type
#491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for the switch statement since we already have direct access to the geometry type. The switch statement is likely a remnant of extracting out geometry type (a _long_ time ago). The only functional difference here is that if a Geometry is somehow constructed with an invalid geometry type (which should be impossible), then the `Type` method will no longer panic but instead just return the invalid geometry type.
|
Thanks for the review! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No need for the switch statement since we already have direct access to the geometry type. The switch statement is likely a remnant of extracting out geometry type (a long time ago). The only functional difference here is that if a Geometry is somehow constructed with an invalid geometry type (which should be impossible), then the
Typemethod will no longer panic but instead just return the invalid geometry type.Check List
Have you:
Added unit tests? Not needed, since there's no testable functional change.
Add cmprefimpl tests? (if appropriate?) N/A.
Updated release notes? (if appropriate?) N/A, not a change that's visible to users.
Related Issue
Benchmark Results