Minor cleanup for radial sorting #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The radial sort 'less' function is extracted out into its own standalone function, making the parent function (`fixVertex`) not need to know about the details of the sort. - A new `XY` method `lengthSq` is added, that computes the square of the length of the distance between the origin and the XY value. - The `Cross` and `lengthSq` methods are used for radial sorting rather than reimplementing the logic for those computations.
albertteoh
approved these changes
Mar 23, 2023
Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
|
Thanks for reviewing 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The radial sort 'less' function is extracted out into its own standalone function, making the parent function (
fixVertex) not need to know about the details of the sort.A new
XYmethodlengthSqis added, that computes the square of the length of the distance between the origin and the XY value.The
CrossandlengthSqmethods are used for radial sorting rather than reimplementing the logic for those computations.Check List
Have you:
Added unit tests? N/A, relies on existing.
Add cmprefimpl tests? (if appropriate?) N/A.
Updated release notes? (if appropriate?) Yes.
Related Issue
Benchmark Results
Not run yet.