Remove constructor options from TransformXY methods #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TransformXY` methods transforms the coordinates of geometries in arbitrary ways via a user-supplied mapping. It should be obvious that this potentially could cause invalid results. For example, the mapping could trivially map every coordinate pair of a polygon to the same point. In practice, transformations are either affine (translation, rotation, scaling), or, at the very least, topologically preserving (e.g. WGS84 to a Mercator or Conic projection). This change removes the choice to validate or not in `TransformXY` methods, always omitting a validation step. Users can still validate manually via the `Validate` method if they wish to.
peterstace
commented
Sep 15, 2023
albertteoh
approved these changes
Sep 22, 2023
|
Thanks for reviewing @albertteoh , I really appreciate it 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
TransformXYmethods transforms the coordinates of geometries in arbitrary ways via a user-supplied mapping. It should be obvious that this potentially could cause invalid results. For example, the mapping could trivially map every coordinate pair of a polygon to the same point. In practice, transformations are either affine (translation, rotation, scaling), or, at the very least, topologically preserving (e.g. WGS84 to a Mercator or Conic projection).This change removes the choice to validate or not in
TransformXYmethods, always omitting a validation step. Users can still validate manually via theValidatemethod if they wish to.Check List
Have you:
Added unit tests? No, however existing tests have been updated.
Add cmprefimpl tests? (if appropriate?) N/A.
Updated release notes? (if appropriate?) No, release notes will be updated when all ctor option related changes have been made.
Related Issue