Remove unchecked point constructors #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renames the `asUncheckedPoint` helper methods on `XY` and `Coordinates` to `asPoint. - Removes the `newUncheckedPoint` function (it's now functionally equivalent to `NewPoint`).
peterstace
changed the title
Base automatically changed from
cleanup_error_handling_in_dcel_renoding
to
master
September 26, 2023 19:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the constructor options and error returns from the
AsPointconstructor method onXY.Adds an
AsPointconstructor method toCoordinates(to shadow the method onXY).Removes the
asUncheckedPointconstructor helper methods.Check List
Have you:
Added unit tests? N/A
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) N/A
Related Issue