Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XY.Less comparison func #585

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

peterstace
Copy link
Owner

Description

XY has Less method to compare two XY values. This logic was duplicated in two other places. This change removes the duplication, instead relying on the Less method.

Check List

Have you:

  • Added unit tests? N/A

  • Add cmprefimpl tests? (if appropriate?) N/A

  • Updated release notes? (if appropriate?) N/A (change too small to both with release notes)

Related Issue

  • N/A

`XY` has `Less` method to compare two `XY` values. This logic was
duplicated in two other places. This change removes the duplication,
instead relying on the `Less` method.
@peterstace peterstace self-assigned this Jan 20, 2024
Copy link
Collaborator

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@peterstace
Copy link
Owner Author

Thanks for reviewing @albertteoh! 😁

@peterstace peterstace merged commit 24d3418 into master Jan 22, 2024
1 check passed
@peterstace peterstace deleted the use_Less_XY_comparison_func branch January 22, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants