Allow the use of pkg-config to be opt-out
#602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems don't have `pkg-config`, or have `pkg-config` that's set up incorrectly. These systems couldn't easily use the `v0.47.1` tag, because that tag introduces a hard dependency on `pkg-config` being used to configure GEOS. This changeset allows `pkg-config` to be opted out of, by using the `sfnopkgconfig` build tag. The behaviour when using that build tag is effectively the same as pre-v0.47.1.
peterstace
commented
Apr 11, 2024
There was a problem hiding this comment.
The #cgo directives only need to be applied once, and are now supplied by either configure_hardcoded.go or configure_pkg_config.go (depending on if the sfnopkgconfig build tag is set or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some systems don't have
pkg-config, or havepkg-configthat's set upincorrectly. These systems couldn't easily use the
v0.47.1tag,because that tag introduces a hard dependency on
pkg-configbeing usedto configure GEOS.
This changeset allows
pkg-configto be opted out of, by using thesfnopkgconfigbuild tag. The behaviour when using that build tag iseffectively the same as pre-v0.47.1.
Check List
Have you:
Added unit tests? Yes.
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) N/A
Related Issue