Add dimension check when parsing WKB GeometryCollections #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that coordinate types are consistent between the geometry collection and its children.
albertteoh
reviewed
May 15, 2024
| if gc.ct == point.ct { | ||
| expectNoErr(t, err) | ||
| } else { | ||
| expectErr(t, err) |
There was a problem hiding this comment.
Should we assert that the error type is mismatchedGeometryCollectionDimsError?
There was a problem hiding this comment.
In theory that would be ideal. However, mismatchedGeometryCollectionDimsError is not exported, so not available in the geom_test package. So we'd either have to:
- Export the error type (I don't want to do that since it's creating more API surface area that makes things harder to change in the future).
- Run the tests in the
geompackage (I also don't want to do that since I prefer to test only the public interface and have that enforced). - Miss the
error.Isassertion (I think that's the best option out of the three, although not ideal).
There was a problem hiding this comment.
Actually.... maybe there is a way to get the best of both worlds. I'll do some experimentation and raise a fix in a new PR if I can get it working.
There was a problem hiding this comment.
I tried something out in #616 (it seems to work pretty well, would love to get your opinion).
albertteoh
approved these changes
May 15, 2024
Base automatically changed from
issue_397_check_geometry_collection_coord_types
to
master
May 15, 2024 19:08
|
Thanks for reviewing! |
peterstace
deleted the
issue_397_check_geometry_collection_coord_types_for_wkb
branch
peterstace
added a commit
that referenced
this pull request
May 15, 2024
This change introduces better error assertions, prompted by a comment from Albert Teoh here: #615 (comment) The change introduces two new test helper functions: - expectErrIs(tb testing.TB, err, want error) - expectErrAs(tb testing.TB, err error, target interface{}) These wrap `errors.Is` and `errors.As` functions from the standard library, respectively. In order for this to work, the `mismatchedGeometryCollectionDimsError` must be exported, but _only during tests_ (because we don't want to expose it to users of the library). This is achieved by using type aliases in a `_test.go` file in the `geom` package. Because `_test.go` files are only included during tests, this is a safe way to expose the type only during tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add dimension check when parsing WKB GeometryCollections
This ensures that coordinate types are consistent between the geometry collection and its children.
Check List
Have you:
Added unit tests? Yes.
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) Yes.
Related Issue