Add GEOS wrapper for GEOSCoverageSimplifyVW_r
#623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See doc comment in `geos/entrypoints.go` for what the function does.
peterstace
commented
Jun 7, 2024
| @@ -1,5 +1,5 @@ | |||
| .PHONY: all | |||
| all: unit lint pgscan cmppg cmpgeos | |||
| all: unit lint geos pgscan cmppg cmpgeos | |||
There was a problem hiding this comment.
This was accidentally missed in a previous change, so slipping it in here.
peterstace
commented
Jun 7, 2024
| }, | ||
| ) | ||
| got, err := geos.CoverageSimplifyVW(input.AsGeometry(), 0.001, false) | ||
| if err != nil && strings.Contains(err.Error(), "unsupported") { |
There was a problem hiding this comment.
I've used string comparison for a sentinel error, which is not ideal.
I plan to fix this using the same treatment as in #616 (there are a few instances in this package that could benefit from it, so I'll do them all at once).
albertteoh
approved these changes
Jun 13, 2024
|
Thanks Albert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See doc comment in
geos/entrypoints.gofor what the function does.Check List
Have you:
Added unit tests? Yes.
Add cmprefimpl tests? (if appropriate?) N/A.
Updated release notes? (if appropriate?) Yes.
Related Issue