Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi-line import statements #22

Closed
wants to merge 1 commit into from

Conversation

kanzure
Copy link
Collaborator

@kanzure kanzure commented Nov 8, 2014

This switches the syntax used for long import lists into a format that
uses multiple lines. One particular benefit of this format is that diffs
more clearly show when certain imported symbols were added or removed.

The original format looks like:

from submodule import x, y, z

And this new format looks like:

from submodule import (
    x,
    y,

    # comments!
    z,
)

This switches the syntax used for long import lists into a format that
uses multiple lines. One particular benefit of this format is that diffs
more clearly show when certain imported symbols were added or removed.

The original format looks like:

    from submodule import x, y, z

And this new format looks like:

    from submodule import (
        x,
        y,

        # comments!
        z,
    )
@petertodd
Copy link
Owner

I don't think it's worth applying this format to the "from future" lines, as they're standardized things that aren't going to change much, if ever; adds clutter at the top of every file.

Applying it to the RPC and network message test modules seems reasonable though. How about you remove the from future changes and I'll merge the other changes.

@petertodd
Copy link
Owner

Went through the code re: imports and cleaned things up; new version is now v0.3.0 release.

@petertodd petertodd closed this Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants