Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport height incorrect (Chrome 31.0.1650.63, Mac OS 10.9) #10

Closed
timmywil opened this issue Dec 9, 2013 · 7 comments · Fixed by #13
Closed

Viewport height incorrect (Chrome 31.0.1650.63, Mac OS 10.9) #10

timmywil opened this issue Dec 9, 2013 · 7 comments · Fixed by #13

Comments

@timmywil
Copy link
Contributor

timmywil commented Dec 9, 2013

If a file path contains a hyphen, a newline is erroneously added (#12). This extra newline seems to cause another error: lines are not viewable once the printed content goes beyond the viewport height of the terminal. Attempting to scroll has no effect.

Docked vertically:
Vertical Docking

Docked horizontally:
screen shot 2013-12-09 at 2 40 21 pm

@timmywil
Copy link
Contributor Author

timmywil commented Dec 9, 2013

Also, it would be great if it would behave more like a terminal and scroll down as lines are printed (if you haven't scrolled up, of course).

@timmywil
Copy link
Contributor Author

I should have done this before, but I just reinstalled and it works fine now. I installed this a while ago and then revisited after Addy's post. Thanks for the fix.

@timmywil
Copy link
Contributor Author

Actually, this wasn't fixed. I just discovered this issue is related to the extra newline with hyphens issue (description updated).

@timmywil timmywil reopened this Dec 10, 2013
@petethepig
Copy link
Owner

Can you please:

  • specify what kind of shell you're using (bash / zsh or maybe something else)
  • provide the output of env command

Thanks

@timmywil
Copy link
Contributor Author

I'm using bash.

Environment
BOLD=
GREEN=
TERM_PROGRAM=iTerm.app
LESS_TERMCAP_md=
COMP_WORDBREAKS=
"'><;|&(:
RESET=
TERM=xterm-256color
SHELL=/bin/bash
HISTSIZE=32768
TMPDIR=/var/folders/3p/6m9jbx0n7j74x3w3p8dlmr6c0000gn/T/
Apple_PubSub_Socket_Render=/tmp/launch-uKvdKz/Render
ORANGE=
LC_ALL=en_US.UTF-8
HISTFILESIZE=32768
USER=timmy
LS_COLORS=no=00:fi=00:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.gz=01;31:*.bz2=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.jpg=01;35:*.jpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.avi=01;35:*.fli=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.ogg=01;35:*.mp3=01;35:*.wav=01;35:
SSH_AUTH_SOCK=/tmp/launch-qo1OWA/Listeners
__CF_USER_TEXT_ENCODING=0x1F5:0:0
MAGENTA=
__CHECKFIX1436934=1
PATH=/usr/local/share/npm/bin:/Users/timmy/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/local/opt/coreutils/libexec/gnubin
PWD=/Users/timmy/code/quickcue-bucket/website
EDITOR=vim
LANG=en_US
ITERM_PROFILE=Hotkey Window
PS1=\[\]\u \[\]at \[\]\h \[\]in \[\]\w\[\]$([[ -n $(git branch 2> /dev/null) ]] && echo " on ")\[\]$(parse_git_branch)\[\]\n$ \[\]
HISTIGNORE=ls:cd:cd -:pwd:exit:date:* --help
HISTCONTROL=ignoredups
PS2=\[\]→ \[\]
MANPAGER=less -X
SHLVL=1
COLORFGBG=7;0
HOME=/Users/timmy
PURPLE=
GREP_OPTIONS=--color=auto
ITERM_SESSION_ID=w0t0p1
LOGNAME=timmy
HOMEBREW_CASK_OPTS=--appdir=/Applications
SECURITYSESSIONID=186a4
WHITE=
OLDPWD=/Users/timmy

@timmywil
Copy link
Contributor Author

After a little investigation, it seems it has to do with the line-break opportunities presented by setting the font to monospace. I think this can be easily fixed by applying this style:

body.platform-mac code,
body.platform-mac .terminal,
body.platform-mac .monospace,
body.platform-mac .source-code {
  ...
  font-family: Menlo, monospace;
  whitespace: pre;
}

@timmywil
Copy link
Contributor Author

I'll submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants