Split AX_COMPILER_FLAGS into sub-macros for different tools #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 26, 2015 11:55
Instead of using ‘-Wno-*’ to disable a warning which the compiler is erroneously emitting, use #pragmas to disable it for a specific source code line.
Unfortunately, the API for AX_COMPILER_FLAGS does not scale for more than two tools, due to the number of parameters required. Without breaking API, split AX_COMPILER_FLAGS out into: • AX_COMPILER_FLAGS_CFLAGS • AX_COMPILER_FLAGS_LDFLAGS and use both of these in the implementation of AX_COMPILER_FLAGS. This means that support for a new tool can be implemented as a separate macro, and used inside AX_COMPILER_FLAGS if deemed necessary, without necessarily needing to add new EXTRA-* parameters for it — if people want to add extra parameters for the tool, they can invoke AX_COMPILER_FLAGS_* manually.
g-ir-scanner is a tool used within a lot of GNOME projects to generate introspection data from C APIs. It has a couple of warning flags (and is not likely to gain any more in the future), and chaining them to --enable-compile-warnings would be useful. Integrate AX_COMPILER_FLAGS_GIR into AX_COMPILER_FLAGS so that it’s enabled by default.
|
Merged, thank you very much for the update. One minor nit:: if you have the chance, please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the two commit messages for justification. Split AX_COMPILER_FLAGS (without breaking its API) into sub-macros for different tools, initially supporting the C compiler and linker, and then adding support for g-ir-scanner from GObject Introspection (https://wiki.gnome.org/Projects/GObjectIntrospection).