Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.map callback called async (closes #1148) #1221

Merged
merged 1 commit into from
Sep 1, 2016
Merged

.map callback called async (closes #1148) #1221

merged 1 commit into from
Sep 1, 2016

Conversation

overlookmotel
Copy link
Contributor

Fix for #1148

@petkaantonov
Copy link
Owner

I wonder if there is same issue with other PromiseArray subclasses as well? like reduce.js

@benjamingr
Copy link
Collaborator

Changes LGTM, if other promise array classes do this - we should just do it in init

@overlookmotel
Copy link
Contributor Author

All other methods call the callback async. I've tested them all. It's only map and filter which have this problem, and this PR fixes both.

@overlookmotel
Copy link
Contributor Author

NB see the tests here: https://github.com/overlookmotel/cls-bluebird/tree/refactor

@petkaantonov petkaantonov merged commit 1739e31 into petkaantonov:master Sep 1, 2016
@overlookmotel overlookmotel deleted the map-async branch September 1, 2016 11:50
@overlookmotel
Copy link
Contributor Author

Any chance of releasing to npm please?

@petkaantonov
Copy link
Owner

I'll be able to release tonight

@overlookmotel
Copy link
Contributor Author

@petkaantonov OK brilliant. Thank you.

@petkaantonov
Copy link
Owner

released

@overlookmotel overlookmotel mentioned this pull request Dec 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@overlookmotel @petkaantonov @benjamingr