Add fallback for unhandled rejection timer on Firefox. #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default unhandled rejection timer is a setTimeout() from a removed iframe. On Firefox, this throws NS_ERROR_NOT_INITIALIZED. This code adds a test to verify that the setTimeout gleaned from the iframe is functional and falls back to the global function if it isn’t. This fixes support for rejecting promises on Firefox. Fixes #1623.
|
Playground at https://jsfiddle.net/m86xou54/ , see behavior in e.g. Firefox-71.0b12 which reproduces the issue. |
The default unhandled rejection timer is a setTimeout() from a removed iframe. On Edge/IE, this can sometimes result in the error “Can't execute code from a freed script”. This restores support for IE/Edge. Fixes #1620.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default unhandled rejection timer is a setTimeout() from a removed
iframe. On Firefox, this throws NS_ERROR_NOT_INITIALIZED. This code
adds a test to verify that the setTimeout gleaned from the iframe is
functional and falls back to the global function if it isn’t.
This fixes support for rejecting promises on Firefox.
Fixes #1623.