Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exception when writing to S3 with fsspec and auto_mkdir=True #512

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Sep 3, 2020

This PR has the objective of fixing a bug when writing to S3.

This is caused by the dependent lib fsspec because it has a parameter auto_mkdir=True for creating folders automatically.

Changes

  1. Fixed the fsspec call passing auto_mkdir=False.
  2. This causes the default behavior being of not to create the folders when missing.

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@juarezr
Copy link
Member Author

juarezr commented Sep 3, 2020

Reporting a issue about this in fsspec.

@coveralls
Copy link

coveralls commented Sep 3, 2020

Coverage Status

Coverage decreased (-0.007%) to 91.953% when pulling 88106f6 on juarezr:fsspec_auto_mkdir into 485d144 on petl-developers:master.

@juarezr juarezr merged commit feeb3be into petl-developers:master Sep 3, 2020
@juarezr juarezr deleted the fsspec_auto_mkdir branch September 17, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants