Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sources from fsspec.registry.register_implementation #533

Merged
merged 9 commits into from
Dec 28, 2020
Merged

Allow sources from fsspec.registry.register_implementation #533

merged 9 commits into from
Dec 28, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Dec 28, 2020 •
edited
Loading

This PR has the objective of adding a feature for custom user-defined source implementations on fsspec.

Changes

  1. Registered handlers from fsspec.registry.register_implementation as remote handlers.
  2. Improved remote testing with tox a little.

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Just a proof of concept
    • Work in progress
    • Ready to review
    • Ready to merge

@coveralls
Copy link

coveralls commented Dec 28, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 91.89% when pulling 6060805 on juarezr:v17 into b22880e on petl-developers:master.

@juarezr juarezr merged commit 8945731 into petl-developers:master Dec 28, 2020
@juarezr juarezr deleted the v17 branch December 28, 2020 21:48
@juarezr juarezr linked an issue Feb 2, 2022 that may be closed by this pull request
Failure during release in Travis CI aborts publishingon readthedocs.io #548
Closed
@juarezr juarezr mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure during release in Travis CI aborts publishingon readthedocs.io
2 participants
@juarezr @coveralls