Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignore_workbook_corruption parameter in xlrd, bump xl… #572

Conversation

arturponinski
Copy link
Collaborator

@arturponinski arturponinski commented Oct 14, 2021

…rd version to 2.0.1. Pass kwargs to xlutils_view.View in XLSView

This PR has the objective of adding support of ignore_workbook_corruption option added to xlrd version 2.0.0
Closes: #571

Changes

  1. Upgrade xlrd package to 2.0.1
  2. Pass kwargs passed to fromxls to xlutils_view.View

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
  • Testing
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

…rd version to 2.0.1. Pass kwargs to xlutils_view.View in XLSView
@coveralls
Copy link

coveralls commented Oct 14, 2021

Coverage Status

Coverage decreased (-0.01%) to 91.322% when pulling a2dcddb on arturponinski:support-corrupted-workbooks-in-xlrd into 095badb on petl-developers:master.

@juarezr juarezr added the Feature A nice to have thing that we don't have yet label Oct 15, 2021
@juarezr juarezr merged commit aaff4e9 into petl-developers:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A nice to have thing that we don't have yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support corrupted workbooks in xlrd
3 participants