Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3.10: start testing petl compatibility #574

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Oct 15, 2021

This PR has the objective of testing compatibility with python 3.10.

Changes

  1. Added a new matrix option to Github Action
  2. Fixed a bug in...
  3. Changed the behaviour of...
  4. Improved the docs about...

Checklist

Checklist for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • ˜(Optional) Tested local against remote servers˜
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • ˜(Optional) Just a proof of concept˜
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@juarezr juarezr added the Maintainability Issues for code modernization, improve development, testing label Oct 15, 2021
@coveralls
Copy link

coveralls commented Oct 15, 2021

Coverage Status

Coverage remained the same at 90.871% when pulling a91b568 on juarezr:py3_10 into a8e8e3f on petl-developers:master.

Copy link
Member Author

@juarezr juarezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • python3.10 is not compatible with nosetests
  • After Migrate to pytest #584 was merged @arturponinski cleared this issue.
  • So now we can start testing python3.10
  • For now, it will be in "simple" mode: no doctests yet
  • Next PR will try with the 'full' mode

@juarezr
Copy link
Member Author

juarezr commented Jan 31, 2022

After #584 CI is passing the tests with python3.10 for:

  • Linux (Ubuntu-latest)
  • Windows
  • macOS
  • Simple Mode: no doctest yet

@juarezr juarezr merged commit bf6873f into petl-developers:master Jan 31, 2022
@juarezr juarezr deleted the py3_10 branch January 31, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants