Fix todataframe() to do not iterate the table multiple times #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting the table data to a list simply with list() causes the table to be materialized three times because list() calls __len__() on the table twice to populate the list. Anyhow, there is no need to have the table data in a list when an iteratotor can be passed to pandas.DataFrame.from_records(). Fixes petl-developers#578.
dnicolodi
force-pushed
the
todataframe-fix
branch
from
251c3ff
to
cbae170
Compare
juarezr
approved these changes
Jan 26, 2022
juarezr
added
Performance
and removed
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the table data to a list simply with list() causes the
table to be materialized three times because list() calls len()
on the table twice to populate the list.
Anyhow, there is no need to have the table data in a list when an
iteratotor can be passed to pandas.DataFrame.from_records().
Fixes #578.