Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: enabe code analysis #603

Merged
merged 1 commit into from Feb 6, 2022

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Feb 4, 2022

This PR has the objective of improving code analysis when using vscode

Changes

  1. Configuring folders for vscode code analysis
  2. Needs python extensions installed on vscode
  3. Needs a python virtual environment with code analysis tools

Checklist

Use this checklist for assuring the quality of pull requests that include new code and or make changes to existing code.

  • Source Code rules apply:
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes are documented in docs/changes.rst
  • Versioning and history tracking rules apply:
    • Using atomic commits when possible
    • Commits are reversible when possible
    • There is no incomplete changes in the pull request
    • There is no accidental garbage added in source code
  • Testing rules apply:
    • Tested locally using tox / pytest
    • Automated testing passes (see CI)
    • Unit test coverage has not decreased (see Coveralls)
  • State of these changes is:
    • Just a proof of concept
    • Work in progress / Further changes needed
    • Ready to review
    • Ready to merge

@juarezr juarezr added the Maintainability Issues for code modernization, improve development, testing label Feb 4, 2022
@coveralls
Copy link

coveralls commented Feb 4, 2022

Coverage Status

Coverage remained the same at 91.759% when pulling 2ca7011 on juarezr:vscode-python-analysis into 1325d20 on petl-developers:master.

@juarezr juarezr merged commit 55326fb into petl-developers:master Feb 6, 2022
@juarezr juarezr deleted the vscode-python-analysis branch February 6, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants