Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest: test tohtml with css styles #609

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Feb 7, 2022

This PR has the objective of

Changes

  1. Added a new test to tohtml testing CSS styles

Checklist

Use this checklist for assuring the quality of pull requests that include new code and or make changes to existing code.

  • Source Code rules apply:
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes are documented in docs/changes.rst
  • Versioning and history tracking rules apply:
    • Using atomic commits when possible
    • Commits are reversible when possible
    • There is no incomplete changes in the pull request
    • There is no accidental garbage added in source code
  • Testing rules apply:
    • Tested locally using tox / pytest
    • Automated testing passes (see CI)
    • Unit test coverage has not decreased (see Coveralls)
  • State of these changes is:
    • Just a proof of concept
    • Work in progress / Further changes needed
    • Ready to review
    • Ready to merge

@juarezr juarezr added the Maintainability Issues for code modernization, improve development, testing label Feb 7, 2022
@coveralls
Copy link

coveralls commented Feb 7, 2022

Pull Request Test Coverage Report for Build 1810257134

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 91.801%

Totals Coverage Status
Change from base Build 1810251735: 0.04%
Covered Lines: 12417
Relevant Lines: 13526

💛 - Coveralls

Copy link
Collaborator

@arturponinski arturponinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests are always welcome

@juarezr juarezr merged commit 206332c into petl-developers:master Feb 8, 2022
@juarezr juarezr deleted the test-html-styles branch February 8, 2022 03:52
@arturponinski arturponinski added this to the v1.7.8 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants