Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix asindices function used in sortheader to support duplicate values… #611

Conversation

arturponinski
Copy link
Collaborator

… passed to spec

This PR has the objective of supporting duplicate column names in sortheader
Closes: #392

Changes

  1. Change asindices to support passing of duplicate values when sorting non-unique column headers

Checklist

Use this checklist for assuring the quality of pull requests that include new code and or make changes to existing code.

  • Source Code rules apply:
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes are documented in docs/changes.rst
  • Versioning and history tracking rules apply:
    • Using atomic commits when possible
    • Commits are reversible when possible
    • There is no incomplete changes in the pull request
    • There is no accidental garbage added in source code
  • Testing rules apply:
    • Tested locally using tox / pytest
    • Automated testing passes (see CI)
    • Unit test coverage has not decreased (see Coveralls)
  • State of these changes is:
    • Just a proof of concept
    • Work in progress / Further changes needed
    • Ready to review
    • Ready to merge

@coveralls
Copy link

coveralls commented Feb 7, 2022

Pull Request Test Coverage Report for Build 1813637635

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 91.975%

Totals Coverage Status
Change from base Build 1813620437: 0.1%
Covered Lines: 12481
Relevant Lines: 13570

💛 - Coveralls

@arturponinski arturponinski force-pushed the fix-sortheader-with-duplicate-column-names branch from 17eeccb to 90f20b7 Compare February 8, 2022 17:06
@arturponinski arturponinski merged commit 90f20b7 into petl-developers:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sortheader() with duplicate column names overlays values
3 participants