Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added separated issue templates for bug and feature request #636

Merged
merged 1 commit into from
Nov 23, 2022
Merged

added separated issue templates for bug and feature request #636

merged 1 commit into from
Nov 23, 2022

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Nov 23, 2022

This PR has the objective of improving issue creation and classification.

Changes

  1. Removed old issue template
  2. Created an issue template for bug
  3. Created an issue template for feature requests

Checklist

Use this checklist to ensure the quality of pull requests that include new code and/or make changes to existing code.

  • Source Code rules apply:
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behavior
    • All changes are documented in docs/changes.rst
  • Versioning and history tracking rules apply:
    • Using atomic commits when possible
    • Commits are reversible when possible
    • There are no incomplete changes in the pull request
    • There is no accidental garbage added to the source code
  • Testing rules apply:
    • Tested locally using tox / pytest
    • Automated testing passes (see CI)
    • Unit test coverage has not decreased (see Coveralls)
  • State of these changes is:
    • Just a proof of concept
    • Work in progress / Further changes needed
    • Ready to review
    • Ready to merge

@juarezr juarezr added the Maintainability Issues for code modernization, improve development, testing label Nov 23, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3534518935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.116%
Totals Coverage Status
Change from base Build 3532338572: 0.0%
Covered Lines: 12758
Relevant Lines: 14002
💛 - Coveralls

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 23, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/feature_request.md

A clear and concise description of what you want to happen.

Whenever relevant, please provide a code sample, of what would be the syntax, the way you

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 89

Expected: 80; Actual: 89
.github/ISSUE_TEMPLATE/bug_report.md
- Operating system (Linux/Windows/Mac)
- How petl was installed (e.g., "using pip into virtual environment", or "using conda")

Also, if you think it might be relevant, please provide the output from ``pip freeze`` or

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 89

Expected: 80; Actual: 89
@juarezr juarezr merged commit 76f12d3 into petl-developers:master Nov 23, 2022
@juarezr juarezr deleted the github-issue-templates branch November 23, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juarezr @coveralls