Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix build as sqlalchemy is not supported yet #650

Merged
merged 1 commit into from Aug 16, 2023

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Aug 16, 2023

This PR has the objective of restricting the maximum supported version of SQLAlchemy.

Changes

  1. Added in requirements-database.txt: SQLAlchemy>=1.3.6,<2.0
  2. Added in setup.py: SQLAlchemy>=1.3.6,<2.0

For SQLAlchemy >=2.0 check #648.

Checklist

Use this checklist to ensure the quality of pull requests that include new code and/or make changes to existing code.

  • Source Code guidelines:
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behavior
    • All changes are documented in docs/changes.rst
  • Versioning and history tracking guidelines:
    • Using atomic commits whenever possible
    • Commits are reversible whenever possible
    • There are no incomplete changes in the pull request
    • There is no accidental garbage added to the source code
  • Testing guidelines:
    • Tested locally using tox / pytest
    • Rebased to master branch and tested before sending the PR
    • Automated testing passes (see CI)
    • Unit test coverage has not decreased (see Coveralls)
  • State of these changes is:
    • Just a proof of concept
    • Work in progress / Further changes needed
    • Ready to review
    • Ready to merge

@juarezr juarezr added the Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge label Aug 16, 2023
@juarezr juarezr merged commit c411e0f into petl-developers:master Aug 16, 2023
34 checks passed
@juarezr juarezr deleted the feature/fix-sqlalchemy-v2 branch August 16, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant