Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: improve lints and vscode settings #658

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Mar 12, 2024

This PR has the objective of improving lints and vscode settings.

Changes

  1. Added configuration for bandit in pyproject.toml to reduce the CI source code analysis false positive (WIP)
  2. Updated VS Code settings for python for working with newer versions
  3. Added VS Code extension recommendations
  4. Improved VS Code debug/launch tasks
  5. Added requirements-linting.txt to easy linters installation

Checklist

Use this checklist to ensure the quality of pull requests that include new code and/or make changes to existing code.

  • Source Code guidelines:
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behavior
    • All changes are documented in docs/changes.rst: Not an user-facing changes
  • Versioning and history tracking guidelines:
    • Using atomic commits whenever possible
    • Commits are reversible whenever possible
    • There are no incomplete changes in the pull request
    • There is no accidental garbage added to the source code
  • [ X Testing guidelines:
    • Tested locally using tox / pytest
    • Rebased to master branch and tested before sending the PR
    • Automated testing passes (see CI)
    • Unit test coverage has not decreased (see Coveralls)
  • State of these changes is:
    • Just a proof of concept
    • Work in progress / Further changes needed
    • Ready to review
    • Ready to merge

@juarezr juarezr self-assigned this Mar 12, 2024
@juarezr juarezr added Maintainability Issues for code modernization, improve development, testing Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge labels Mar 12, 2024
@coveralls
Copy link

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8254917834

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.072%

Totals Coverage Status
Change from base Build 8253998504: 0.0%
Covered Lines: 13352
Relevant Lines: 14661

💛 - Coveralls

.vscode/launch.json Fixed Show fixed Hide fixed
.vscode/extensions.json Fixed Show fixed Hide fixed
examples/notes/issue_219.py Dismissed Show dismissed Hide dismissed
examples/notes/issue_219.py Dismissed Show dismissed Hide dismissed
.vscode/launch.json Fixed Show fixed Hide fixed
@juarezr juarezr merged commit 318facd into petl-developers:master Mar 12, 2024
36 checks passed
@juarezr juarezr deleted the chore/improve-lints branch March 12, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants