Add option to raise error, if .env file does not exist #1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Envy#load and Envy#load! with block, that takes a hash of
configuration '{ raise_exception: true }'.
petoem
reviewed
Feb 11, 2018
src/envy.cr
Outdated
| def {{name.id}}(hash : Hash(String, String)) | ||
| hash.each do |key, value| | ||
| ENV[key] {{comp.id}} value | ||
| end | ||
| end | ||
| {% end %} | ||
|
|
||
| def parse(filename : String) : Hash(String, String) | ||
| def parse(filename : String, hash = {} of Symbol => Bool) : Hash(String, String) |
There was a problem hiding this comment.
Calling it option would be more descriptive than hash.
|
I love it. |
|
Awesome!! I'll be pushing that update right now. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to the issue I opened #1 , please let me know your thoughts about it 馃檹