feat(server): add options directly to Start wrapper

petomalina · Nov 22, 2021 · f965b84 · f965b84
1 parent 8030b96
commit f965b84
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/examples/grpc-http/main.go b/examples/grpc-http/main.go
@@ -52,7 +52,11 @@ func main() {
 		logger.Fatal("gw: failed to register: %v", zap.Error(err))
 	}
 
-	srv, err := server.New(os.Getenv("PORT"), time.Second*30)
+	srv, err := server.New(
+		os.Getenv("PORT"),
+		time.Second*30,
+		server.WithHost("localhost"),
+	)
 	if err != nil {
 		logger.Fatal("xrpc: cannot create server: %v", zap.Error(err))
 	}

diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -46,8 +46,8 @@ func New(port string, timeout time.Duration, opts ...Option) (*server, error) {
 }
 
 // Start bootstraps a default http server and starts handling requests
-func Start(ctx context.Context, port string, timeout time.Duration, handler http.Handler) error {
-	srv, err := New(port, timeout)
+func Start(ctx context.Context, port string, timeout time.Duration, handler http.Handler, opts ...Option) error {
+	srv, err := New(port, timeout, opts...)
 	if err != nil {
 		return err
 	}