Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new class detection #9

Merged
merged 1 commit into from May 9, 2018
Merged

Fix new class detection #9

merged 1 commit into from May 9, 2018

Conversation

petr-muller
Copy link
Owner

Previously, classes present in both versions of the file were reported
as new, which was caused by a buggy difference computation.

Previously, classes present in both versions of the file were reported
as new, which was caused by a buggy difference computation.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 51

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 49: 0.0%
Covered Lines: 260
Relevant Lines: 260

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         257    260    +3     
=====================================
+ Hits          257    260    +3
Impacted Files Coverage Δ
pyff/pyff.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da248ea...c4646a7. Read the comment docs.

@petr-muller petr-muller merged commit a58c7b0 into master May 9, 2018
@petr-muller petr-muller deleted the fix-class-detection branch May 9, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants