Skip to content

Commit

Permalink
Merge pull request #4 from ppraisethesun/fix_specs
Browse files Browse the repository at this point in the history
fixed type specs in petrovich.ex
  • Loading branch information
sobolevn committed Mar 12, 2019
2 parents 017bcbc + 8e02168 commit 60c4ac5
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions lib/petrovich.ex
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,10 @@ defmodule Petrovich do
def start(_type, _args) do
import Supervisor.Spec, warn: false

children =
[
worker(Petrovich.NameStore, []),
worker(Petrovich.GenderStore, []),
]
children = [
worker(Petrovich.NameStore, []),
worker(Petrovich.GenderStore, [])
]

opts = [strategy: :one_for_one, name: Petrovich.Supervisor]
Supervisor.start_link(children, opts)
Expand All @@ -59,15 +58,16 @@ defmodule Petrovich do
{:ok, "Кире"}
"""
@spec firstname(String.t, atom(), atom() | none()) :: {atom(), String.t}
@spec firstname(String.t(), atom(), atom() | none()) ::
{:ok, String.t()} | :error
def firstname(name, case_, gender \\ @default_gender) do
Parser.parse(name, :firstname, case_, gender)
end

@doc """
The same as `firstname/3`, but raises `ParseException` on errors.
"""
@spec firstname!(String.t, atom(), atom() | none()) :: String.t
@spec firstname!(String.t(), atom(), atom() | none()) :: String.t()
def firstname!(name, case_, gender \\ @default_gender) do
Parser.parse!(name, :firstname, case_, gender)
end
Expand All @@ -90,15 +90,16 @@ defmodule Petrovich do
{:ok, "Викторовне"}
"""
@spec middlename(String.t, atom(), atom() | none()) :: {atom(), String.t}
@spec middlename(String.t(), atom(), atom() | none()) ::
{:ok, String.t()} | :error
def middlename(name, case_, gender \\ @default_gender) do
Parser.parse(name, :middlename, case_, gender)
end

@doc """
The same as `middlename/3`, but raises `ParseException` on errors.
"""
@spec middlename!(String.t, atom(), atom() | none()) :: String.t
@spec middlename!(String.t(), atom(), atom() | none()) :: String.t()
def middlename!(name, case_, gender \\ @default_gender) do
Parser.parse!(name, :middlename, case_, gender)
end
Expand All @@ -121,15 +122,16 @@ defmodule Petrovich do
{:ok, "Гореве"}
"""
@spec lastname(String.t, atom(), atom() | none()) :: {atom(), String.t}
@spec lastname(String.t(), atom(), atom() | none()) ::
{:ok, String.t()} | :error
def lastname(name, case_, gender \\ @default_gender) do
Parser.parse(name, :lastname, case_, gender)
end

@doc """
The same as `lastname/3`, but raises `ParseException` on errors.
"""
@spec lastname!(String.t, atom(), atom() | none()) :: String.t
@spec lastname!(String.t(), atom(), atom() | none()) :: String.t()
def lastname!(name, case_, gender \\ @default_gender) do
Parser.parse!(name, :lastname, case_, gender)
end
Expand Down

0 comments on commit 60c4ac5

Please sign in to comment.