Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump credo from 1.2.3 to 1.3.0 #37

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps credo from 1.2.3 to 1.3.0.

Changelog

Sourced from credo's changelog.

1.3.0

  • Enable UnnecessaryAliasExpansion check by default

  • Fix bugs when removing heredocs and charlists from sources

  • Fix false positive on TrailingWhiteSpace

  • Add ignore: [:fun1, :fun2] param to all UnusedOperation* checks; to ignore unused Enum.reduce/3 operations, use

    {Credo.Check.Warning.UnusedEnumOperation, [ignore: [:reduce]]},
    

New switch to re-enable disabled checks

Use --enable-disabled-checks [pattern] to re-enable checks that were disabled in the config using {CheckModule, false}. This comes in handy when using checks on a case-by-case basis

As with other check-related switches, pattern is a comma-delimted list of patterns:

$ mix credo info --enable-disabled-checks Credo.Check.Readability.Specs,Credo.Check.Refactor.DoubleBooleanNegation

Of course, we can have the same effect by choosing the pattern less explicitly:

$ mix credo info --enable-disabled-checks specs,double

New API for custom checks

This deprecates the mandatory use of @explanation and @default_params module attributes for checks.

Before v1.3 you had to define module attributes named @explanation and @default_params before calling use Credo.Check.

Now you can pass :explanations (plural) and :param_defaults options directly to use Credo.Check.

defmodule MyCheck do
  use Credo.Check,
    category: :warning,
    base_priority: :high,
    param_defaults: [param1: 42, param2: "offline"],
    explanations: [
      check: "...",
      params: [
        param1: "Your favorite number",
        param2: "Online/Offline mode"
      ]
    ]
def run(source_file, params) do
#
end
end

... (truncated)
Commits
  • 352fb9a Bump version to 1.3.0
  • 1762b75 Update CHANGELOG
  • 606a65c Update base_priority typespec
  • 08e99d6 Merge pull request #761 from TheFirstAvenger/mb-fix-base-priority-type
  • b807847 Merge pull request #762 from TheFirstAvenger/mb-formatting-issue
  • 5094056 Removed commented out IO.inspect (and appease formatter)
  • 7db9cc8 Fix mismatch in base_priority type
  • 6242255 Merge pull request #756 from pdgonzalez872/pg-improve-docs
  • e9914ab Merge pull request #760 from wevtimoteo/update-mox-repo-url
  • 571145d Merge pull request #759 from sourcelevel/add-sourcelevel-to-automated-code-re...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [credo](https://github.com/rrrene/credo) from 1.2.3 to 1.3.0.
- [Release notes](https://github.com/rrrene/credo/releases)
- [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md)
- [Commits](rrrene/credo@v1.2.3...v1.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels Mar 9, 2020
@sobolevn sobolevn merged commit 1d7d973 into master Mar 10, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/hex/credo-1.3.0 branch March 10, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant