Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces references to the 'sys' module with 'util'. #29

Merged
merged 2 commits into from
Nov 14, 2011
Merged

Replaces references to the 'sys' module with 'util'. #29

merged 2 commits into from
Nov 14, 2011

Conversation

atourino
Copy link
Contributor

This is a simple search / replace job enabling supervisor to work with later node versions. From the changelog, the sys to util renaming occurred with node 0.3 so this patch will probably require node 0.3+ but I haven't tested any node versions before 0.6 which is what I have installed.

@mikl
Copy link

mikl commented Nov 12, 2011

I tried out your branch with this npm command

npm install https://github.com/atourino/node-supervisor/tarball/replace_sys_reference_to_util -g

Sadly, this does not seem to work with Node.js 0.6:

npm ERR! Unsupported
npm ERR! Not compatible with your version of node/npm: supervisor@0.1.3
npm ERR! Required: {"node":"~0.2.3 || 0.3 || 0.4 || 0.5"}
npm ERR! Actual:   {"npm":"1.0.105","node":"0.6.1"}
npm ERR! 
npm ERR! System Darwin 11.2.0
npm ERR! command "node" "/usr/local/bin/npm" "install" "https://github.com/atourino/node-supervisor/tarball/replace_sys_reference_to_util" "-g"
npm ERR! cwd /Users/mikl/Work/Node/ardon
npm ERR! node -v v0.6.1
npm ERR! npm -v 1.0.105
npm ERR! code ENOTSUP
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/mikl/Work/Node/ardon/npm-debug.log
npm not ok

If I add -f to the install command, it installs as intended.

You need to fix the supported versions in package.json :)

This aside, supervisor works great on 0.6 with this patch applied.

@atourino
Copy link
Contributor Author

Thanks for the pointer @mikl!

@iangreenleaf iangreenleaf merged commit b63a4a8 into petruisfan:master Nov 14, 2011
@iangreenleaf
Copy link
Collaborator

Thanks! It looks like the package was already not working with node < 0.3.7, so this should be no problem.

@iangreenleaf iangreenleaf mentioned this pull request Jan 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants