Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for node's --debug and --debug-brk flags #50

Closed
wants to merge 3 commits into from

Conversation

blipboard
Copy link

No description provided.

@iangreenleaf
Copy link
Collaborator

We've discussed a --debug flag in #48 for noisier logs, which would conflict with this. Not sure which is the more "expected" behavior.

Also relevant is #49, where we discuss the difficulty of passing arguments through to node or coffee. This pull request is probably the most common use case for that need.

@randallb
Copy link

randallb commented May 2, 2012

So just voicing my opinion, this is totally something I want / need. node-inspector is a total godsend, and combine it with supervisor, and my dev life just gets easier and easier.

My usecase is precisely the #51 one.

@iangreenleaf
Copy link
Collaborator

I'm leaning towards thinking that this use of --debug is probably more important and expected than #48's. Unfortunately, this change won't work with CoffeeScript, since that needs an extra parameter. We could perhaps add awareness of that and include the extra parameter automatically, though it's toeing a fine line of special-case feature support.

@iangreenleaf
Copy link
Collaborator

[snip]

@iangreenleaf
Copy link
Collaborator

Actually, I'm gonna move that discussion to #49. It might still be worth writing these two flags in as special cases, just to be nice to users.

@lookfirst
Copy link

wow, I seriously need this. why is this still open for 5+ months?

lookfirst added a commit to lookfirst/node-supervisor that referenced this pull request Aug 13, 2012
@iangreenleaf
Copy link
Collaborator

@lookfirst you can achieve the same functionality using --, like so:

supervisor -- --debug app.coffee

However, I recognize that this feature would be nice to have, and will probably add support for it soon.

@lookfirst
Copy link

Weird, I thought I tried that and it didn't work. Needless to say, just writing supervisor -d web to run my app sure is a lot nicer.

@iangreenleaf
Copy link
Collaborator

Thanks for the patch. This is finally included in v0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants