Disable immediate allocation for NP jobs #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 61.39% 61.31% -0.08%
==========================================
Files 32 32
Lines 2531 2531
Branches 416 416
==========================================
- Hits 1554 1552 -2
- Misses 896 897 +1
- Partials 81 82 +1
Continue to review full report at Codecov.
|
rmfan
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_allocate_onelooks at existing pods to look for an available node for the newly-added job. There could be a situation where two consecutive non-preemptible jobs can both get the same allocation because the earlier job haven't spawned any replica pods yet. This can trigger a reallocation for the second non-preemptible job at a later full allocation cycle which crashes the allocator because it violates the basic assumption about pinned non-preemptible jobs. This fix only allows this optimization for preemptible jobs.