Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support apiextensions.k8s.io/v1 and admissionregistration.k8s.io/v1 #118

Merged
merged 7 commits into from
Apr 19, 2022

Conversation

odp
Copy link
Collaborator

@odp odp commented Apr 18, 2022

Kubernetes v1.22 has discontinued support for apiextensions.k8s.io/v1beta1 and admissionregistration.k8s.io/v1beta1 used by AdaptDL. This MR:

  1. Adds support for v1 APIs according to this migration guide
  2. Fixes validator service to accept adaptdl.petuum.com/v1, so that it does proper validation of CR request.

v1 is supported from k8s v1.16 onwards. Tested the MR on v1.19 and v1.22

@odp odp requested a review from rmfan April 18, 2022 18:48
rmfan
rmfan previously approved these changes Apr 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #118 (91cec08) into master (4d8afa5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   61.39%   61.39%           
=======================================
  Files          32       32           
  Lines        2531     2531           
  Branches      416      416           
=======================================
  Hits         1554     1554           
  Misses        896      896           
  Partials       81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8afa5...91cec08. Read the comment docs.

@odp odp merged commit 16bc63c into petuum:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants