Fix reaction matching behaviour

Some unit tests were failing silently because all exceptions were
being rescued (fixed in ab0dcac).

Fix matching behaviour: invoke all matching reactions, or the
first defined default reaction, if no matches.

lib/hipbot/matchable.rb

@@ -22,15 +22,21 @@ def reactables
       plugins.map(&:class)
     end
 
-    def presence_reaction_sets
-      reactables.map(&:presence_reactions)
+    def reaction_sets
+      defined_reaction_sets + default_reaction_sets
     end
 
-    def reaction_sets
-      reactables.each_with_object([]) do |reactable, array|
-        array.unshift(reactable.reactions)
-        array.push(reactable.default_reactions)
-      end
+    def defined_reaction_sets
+      reactables.map(&:reactions)
+    end
+
+    def default_reaction_sets
+      # Each default reaction is alone in its own reaction set
+      reactables.flat_map(&:default_reactions).map { |r| [r] }
+    end
+
+    def presence_reaction_sets
+      reactables.map(&:presence_reactions)
     end
 
     def set_matches sets, message

spec/unit/bot_spec.rb

@@ -46,10 +46,11 @@
       subject.react(sender, room, '@robot hello robot!')
     end
 
-    it "should choose first option when multiple options match" do
+    it "should choose all matching options" do
       described_class.on /hello there/ do reply('hello there') end
       described_class.on /hello (.*)/ do reply('hello') end
       subject.should_receive(:send_to_room).with(room, 'hello there')
+      subject.should_receive(:send_to_room).with(room, 'hello')
       subject.react(sender, room, '@robot hello there')
     end