-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples folder organisation #161
Comments
Or even better we could contribute to sketchbook-cli as gallery export in on wishlist there. |
helpers.js -> that should be in pex-renderer core or pex-helpers @dmnsgn any feedback on this? Is there current setup messy for you? Can we live with one webpack js file or should we move sources to /src or build scripts to /lib ? |
Ideal examples structure:
We're close to that, we just need to move helpers. Scripts could be in their own packages as well, as it would be nice to unify pex-renderer/context/gui/gl examples workflow.
Are you still talking about the examples here or pex-renderer lib? If the latter, we could have a single file at root folder with two entries:
|
So i guess the next step is to implement #72 and remove helpers |
v4: helpers are in core now, esm and snowdev usage means no build step. |
We have moved to one js file per example structure with
example-name.js
files. That's great. But now we also havenon-example-file.js
there likebuild.js
orhelpers.js
. It's a bit confusing as you need to read the source to find it is it example or not. It additionally breaks sketchbook-cli (multi file budo-like runner).Proposal:
examples/build.js
toexamples/scripts/build.js
examples/helpers.js
toexamples/helpers/index.js
orexamples/lib/helpers.js
examples/examples.js
becomes then unnecessary as you can just dofs.readdir
and filter all js files that we now know are only example files.examples/index.html
can be then generated tooMissing
common.js
index.js
The text was updated successfully, but these errors were encountered: