Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer crashes on directional lights that don't cast shadows #345

Closed
vorg opened this issue Jul 4, 2023 · 1 comment
Closed

Renderer crashes on directional lights that don't cast shadows #345

vorg opened this issue Jul 4, 2023 · 1 comment
Labels
type/fix A bug fix
Projects
Milestone

Comments

@vorg
Copy link
Member

vorg commented Jul 4, 2023

Can't set uniform "uDirectionalLights[1].projectionMatrix" with a null value as the _projectionMatrix is never defined (only for lights with castShadows) and yet it's required by renderer's uniform setting code

@dmnsgn dmnsgn added this to the 4.0.0 milestone Sep 11, 2023
@dmnsgn dmnsgn added the type/fix A bug fix label Sep 11, 2023
@dmnsgn dmnsgn added this to To do in 4.0.0 via automation Sep 11, 2023
@dmnsgn
Copy link
Member

dmnsgn commented Sep 11, 2023

Everything is set by:

@dmnsgn dmnsgn closed this as completed Sep 11, 2023
4.0.0 automation moved this from To do to Done Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix A bug fix
Projects
4.0.0
  
Done
Development

No branches or pull requests

2 participants