Ensure venv pex does not enter a re-exec loop. #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same environment variable trick used by pex_bootstrapper to ensure we never enter aninifinite re-exec loop. Also check more valid venv python path variants by resolving symlinks in the parent directories of the known valid pythons. Fixes pex-tool#1285
Eric-Arellano
approved these changes
Mar 25, 2021
|
Confirmed this fixed it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same environment variable trick used by pex_bootstrapper to
ensure we never enter aninifinite re-exec loop. Also check more valid
venv python path variants by resolving symlinks in the parent
directories of the known valid pythons.
Fixes #1285