Simplify PEX teardown / leave stderr in tact.
#1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For historical reasons that are no longer relevant, `PEX` accrued complicated teardown code that, among other things, replaced `sys.stderr` with `/dev/null`. This could lead to lost messages to stderr. Simply remove the complicated and no-longer useful code. Fixes pex-tool#1802
benjyw
reviewed
Jun 19, 2022
pex/variables.py
Outdated
| @@ -235,6 +235,11 @@ def __init__(self, environ=None, rc=None): | |||
| "The `PEX_UNZIP` env var is deprecated. This env var is no longer read since " | |||
| "unzipping PEX zip files before execution is now the default." | |||
| ) | |||
| if "PEX_TEARDOWN_VERBOSE" in self._environ: | |||
| pex_warnings.warn( | |||
| # TODO(John Sirois): XXX | |||
benjyw
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons that are no longer relevant,
PEXaccruedcomplicated teardown code that, among other things, replaced
sys.stderrwith/dev/null. This could lead to lost messages tostderr. Simply remove the complicated and no-longer useful code.
Fixes #1802