Fix interpreter resolution when using --complete-platform with --resolve-local-platforms #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he available interpreter
…l-platforms Added an extra test for interpreter resolution when the interpreter supported_tags are a subset of the requested complete-platform's supported_tags. Tweaked the code to ensure this test passes.
jsirois
approved these changes
Jan 9, 2023
pex/resolve/target_configuration.py
Outdated
| "Searching for local interpreters matching {}".format( | ||
| ", ".join(map(str, all_platforms)) | ||
| ) | ||
| "Searching for local interpreters matching ".format(", ".join(platform_strs)) |
There was a problem hiding this comment.
The fmt shard error caught this - missing {}.
There was a problem hiding this comment.
Thanks for pinpointing @jsirois - fix committed - waiting for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2026.
Previously the interpreter resolution was more strict than necessary. The
supported_tagswere only checked if the most specific tag of the complete platform matched the platform of the local interpreter. This prevented resolution in cases when it was possible and safe (ie allsupported_tagsof the interpreter as present in thesupported_tagsof the complete-platform).Added an additional test for the above case. Fixed existing code and also improved various existing tests by adding
expected_complete_platforms.