Fix symlinked venv ns-package calcs. #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPython can inject ~PS1-style prefixes depending on the IPython version and Python version in-play. Avoid having to worry about this with a dedicated test communication channel separate from stdio.
It turns out PyPy 7.3.12 has them! In particular hpy.
Previously namespace packages were handled only amongst 3rd-party deps. Any ns-package also split across PEX user sources would lead to one of the 3rd-party dep members of the namespace package getting its cached wheel install contaminated with the PEX user source that was a member of the ns-package. Fixes pex-tool#2160
jsirois
commented
Jul 2, 2023
| assert ProjectName("top_level") == top_level.metadata.project_name | ||
| assert Version("0.1.0") == top_level.metadata.version | ||
|
|
||
| assert [os.path.join(top_level.location, "top_level", "lib.py")] == [ |
There was a problem hiding this comment.
This test fails pre-fix for 2/9 cases as expected: symlinked venv {packed,zipapp}
Use pkgutil namespace packages and older setuptools config style.
benjyw
approved these changes
Jul 2, 2023
|
|
||
| top_level_library = os.path.join(top_level_project, "top_level", "lib.py") | ||
| with safe_open(top_level_library, "w") as fp: | ||
| fp.write("OG = 'Henry Barber'") |
There was a problem hiding this comment.
(I had to look him up though)
There was a problem hiding this comment.
I grew up trying to climb Barber routes, sometimes succeeding. It's been a long time but just got on another one many years later out at the Ophir Wall. Even if not physically challenged it's almost certain he'll have provided a mental one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously namespace packages were handled only amongst 3rd-party deps.
Any ns-package also split across PEX user sources would lead to one of
the 3rd-party dep members of the namespace package getting its cached
wheel install contaminated with the PEX user source that was a member of
the ns-package.
Fixes #2160