Trim embedded doc image assets. #2368
Conversation
Re-use the Pex icon png for the favicon and delete `pex.ico`. Browser support for png favicons is both wide and deep at this point and removing the ~46KB `.ico` file trims ~20KB from the binary distributions we release. Also re-name pex-full* assets to pex-logo* to reflect their role and tidy up the SVG source. There is the SVG source and then the logo and icon derived from it. This should be a bit more clear now.
|
The doc-site for this branch is deployed and viewable here: https://jsirois.github.io/pex/ |
| @@ -106,5 +106,5 @@ | |||
| simplepdf_vars = { | |||
| "primary": "#ffcc00", | |||
| "cover": "black", | |||
| "cover-bg": "url(pex-cover.png) no-repeat center", | |||
| "cover-bg": "url(pex-icon.png) no-repeat center", | |||
There was a problem hiding this comment.
Sorry about that, https://jsirois.github.io/pex/_static/pex.pdf was missing the cover page artwork. Now re-deployed and looking correct.
| # Confusing! The white gets applied to the page number color (which appears inside a rusty red | ||
| # box) and the back cover text color. Neither white nor black work well for the back page text | ||
| # color since the text intersects the thick black bottom arc of the Pex P-egg. The yolk color | ||
| # works well enough in both these spots though. | ||
| "white": "#ffee00", |
There was a problem hiding this comment.
Alright, that's it from me. Sorry for the thrash.
The PDF looks good enough. Site re-deployed with this change and the PDF link is the PDF icon on the bottom bar: https://jsirois.github.io/pex/
Yes, and an upside down egg looks like a P if you squint. Most directly though, eggs perhaps introduced the idea of a zipapp to the wider world with eggsecutables in 2006: pypa/setuptools@ae347c1 |
Re-use the Pex icon png for the favicon and delete
pex.ico. Browsersupport for png favicons is both wide and deep at this point and
removing the ~46KB
.icofile trims ~20KB from the binary distributionswe release.
Also re-name pex-full* assets to pex-logo* to reflect their role and
tidy up the SVG source, adding its license to the metadata. There is
the SVG source and then the logo and icon derived from it. This should
be a bit more clear now.