Fix lock downloads to use all lock info. #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the lock target systems and requires python configuration were left out, which could lead to critical Pip runtime patches being left off; causing downloads to fail when they should not. Fixes pex-tool#2395
jsirois
commented
Apr 11, 2024
| complete_platform = data.path("platforms", "complete_platform_linux_x86-64_py11.json") | ||
| pex = os.path.join(str(tmpdir), "pex") | ||
| shutil.rmtree(pex_root) | ||
| run_pex_command( |
There was a problem hiding this comment.
After the 1st commit this fails just like the reported repro case:
...
__________________________________________________________________________________ test_download_incompatible_python
...
E pex: Building pex :: Resolving distributions for requirements: pbipy==2.8.2 :: Resolving requirements from lock file /tmp/pytest-of-jsirois/pytest-8/test_download_incompatible_pyt0/lock.json :: Categorizing 8 downloaded artifacts
E There was 1 error downloading required artifacts:
E 1. pbipy 2.8.2 from http://0.0.0.0:41645/root/pypi/%2Bf/fc9/ff27ad81b2ee3/pbipy-2.8.2-py2.py3-none-any.whl
E ERROR: Package 'pbipy' requires a different Python: 3.9.13 not in '>=3.10'
testing/__init__.py:380: AssertionError
======================================================================================= short test summary info =======================================================================================
FAILED tests/integration/test_issue_2395.py::test_download_incompatible_python - AssertionError: integration test failed: return_code=1, output=, error=pex: Parsing lock /tmp/pytest-of-jsirois/pytest-8/test_download_incompatible_pyt0/lock.json
zmanji
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the lock target systems and requires python configuration
were left out, which could lead to critical Pip runtime patches being
left off; causing downloads to fail when they should not.
Fixes #2395