Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installers to be insensitive to extras iteration order. #532

Merged
merged 2 commits into from
Jul 28, 2018
Merged

Fix installers to be insensitive to extras iteration order. #532

merged 2 commits into from
Jul 28, 2018

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jul 27, 2018

Fixes #158

@jsirois
Copy link
Member Author

jsirois commented Jul 27, 2018

NB: With just the test added and no fix, tox -epy27 -- -vsktest_installer.py consistently failed for test_setuptools_before_wheel.

@jsirois jsirois mentioned this pull request Jul 27, 2018
Merged
@jsirois
Copy link
Member Author

jsirois commented Jul 27, 2018 •
edited

Noting that test_no_wheel fails for @CMLivingston under tox -epypy and we went through a battery of debugging to confirm his .pyenv_test/versions/3.6.3/ interpreter - used by that test - was not contaminated with wheel. I'm at a loss but I'd like to solve this. We have a host of issues like this and it would be lovely not to paper over.

@jsirois
Copy link
Member Author

jsirois commented Jul 28, 2018

Alright, proceeding since Chris and I confirmed his pypy env is borked. Not satisfying.

@jsirois jsirois merged commit 685757e into pex-tool:master Jul 28, 2018
@jsirois jsirois deleted the issues/158 branch July 28, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwlzn kwlzn kwlzn approved these changes

@CMLivingston CMLivingston Awaiting requested review from CMLivingston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsirois @kwlzn