WIP: ensure that sdist resolution is reproducible #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2019
Eric-Arellano
force-pushed
the
reproducible-sdist
branch
from
715d9ee
to
9e926eb
Compare
jsirois
reviewed
Mar 2, 2021
| @@ -1752,30 +1753,49 @@ def assert_reproducible_build(args): | |||
| # from the random seed, such as data structures, as Tox sets this value by default. See | |||
| # https://tox.readthedocs.io/en/latest/example/basic.html#special-handling-of-pythonhashseed. | |||
| def create_pex(path, seed): | |||
| result = run_pex_command(args + ["-o", path], env=make_env(PYTHONHASHSEED=seed)) | |||
| result = run_pex_command( | |||
| args + ["-o", path, "--disable-cache"], env=make_env(PYTHONHASHSEED=seed) | |||
There was a problem hiding this comment.
The only issue here is --disable-cache which causes a new tmp dir to be used for each PEX build. Since part of a PEX build is a pip install of all downloaded and built wheels, this leaves a direct_url.json file in the dist-info of each installed wheel chroot with a varying local file:// url. See: https://packaging.python.org/specifications/direct-url/#specification
The upshot is that the built PEX is stable when the PEX_ROOT is stable which will be the case that Pants cares mainly about. It still may make sense to delete that file though and its record in RECORD but I need to put some more thought into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
tox -e py37-integration -- -k test_reproducible_build_sdistto reproduce the now failing test.